Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe cast for Kotlin 1.4 #1142

Closed
wants to merge 5 commits into from
Closed

Unsafe cast for Kotlin 1.4 #1142

wants to merge 5 commits into from

Conversation

jcenturion18
Copy link

@jcenturion18 jcenturion18 commented Dec 17, 2020 •
edited

Fixes #1134

Before fix:

Screen Shot 2020-12-17 at 21 52 49

Publishing 0.8.7-SNAPSHOT in local version

Screen Shot 2020-12-17 at 21 53 46

@Godin Godin self-assigned this Dec 17, 2020
@Godin
Copy link
Member

Godin commented Dec 18, 2020

Thank you for your contribution @jcenturion18

However

  • Update of Kotlin to 1.4.0 in org.jacoco.core.test.validation.kotlin/pom.xml is missing in this PR.
  • Also IMO it introduces unnecessary code duplication between new and old files, which can be avoided.

Closing it in favour of #1143

@Godin Godin closed this Dec 18, 2020
@jcenturion18
Copy link
Author

jcenturion18 commented Dec 18, 2020 •
edited

Thank you for your contribution @jcenturion18

However

  • Update of Kotlin to 1.4.0 in org.jacoco.core.test.validation.kotlin/pom.xml is missing in this PR.

  • Also IMO it introduces unnecessary code duplication between new and old files, which can be avoided.

Closing it in favour of #1143

@Godin No worries. I was trying to help. I read your code, much better!

@Godin Godin added the declined: duplicate ❌ This issue or pull request already exists label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lugarbarini lugarbarini lugarbarini approved these changes

Assignees

@Godin Godin

Labels
declined: duplicate ❌ This issue or pull request already exists
Projects
None yet
Milestone
No milestone
3 participants
@jcenturion18 @Godin @lugarbarini