Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KotlinDefaultMethodsFilter should also filter methods with parameters #1137

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Godin
Copy link
Member

@Godin Godin commented Dec 16, 2020

See #905 (comment)

Filter added by #1012 in version 0.8.6 doesn't take into account

  • methods with parameters
  • methods consisting of super call followed by code other than return
  • methods consisting of super call of method with different name

In the following example

interface I {
  fun m(p: Int) = Unit
}

class C : I {
}

method m generated by Kotlin compiler in C should be filtered out.


In the following example

interface I {
  fun m() = Unit
}

class C : I {
  override fun m() {
    super.m()
    println()
  }
}

method m in C should not be filtered out.


In the following example

interface I {
  fun m1() = Unit
  fun m2() = Unit
}

class C : I {
  override fun m1() {
    super.m2()
  }
}

method m1 in C should not be filtered out.

@Godin Godin added this to the 0.8.7 milestone Dec 16, 2020
@Godin Godin self-assigned this Dec 16, 2020
@Godin Godin added this to To Do in Filtering via automation Dec 16, 2020
@Godin Godin added this to Candidates in Current work items via automation Dec 16, 2020
@Godin Godin marked this pull request as draft December 16, 2020 16:38
@Godin Godin moved this from Candidates to Implementation in Current work items Dec 16, 2020
@Godin Godin moved this from To Do to In Progress in Filtering Dec 26, 2020
ragunathjawahar added a commit to redgreenio/timelapse that referenced this pull request Feb 7, 2021
@Godin Godin modified the milestones: 0.8.7, 0.8.8 May 3, 2021
@mirabilos
Copy link

Can you please move this to 0.8.9 and release 0.8.8 in the meantime? I don’t use Kotlin, but I do need the assert filtering… Thanks in advance!

@alisonthemonster
Copy link

Would love to have this in jacoco 0.8.8! Any updates here?

@marchof
Copy link
Member

marchof commented Jul 9, 2021

@alisonthemonster We're working in our spare time and completely transparently: All information and the current status of the implementation can be seen in this pull request.

@Godin Godin modified the milestones: 0.8.8, 0.8.9 Apr 4, 2022
@pexa-adash
Copy link

Looks good.
When is the 0.8.9 release tentatively expected by?

@Godin Godin modified the milestones: 0.8.9, 0.8.10 Mar 31, 2023
@Godin Godin modified the milestones: 0.8.10, 0.8.11 Apr 24, 2023
@Godin Godin modified the milestones: 0.8.11, 0.8.12 Oct 14, 2023
@Godin Godin removed this from the 0.8.12 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Current work items
  
Implementation
Filtering
  
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants