Skip to content

Commit

Permalink
Remove URLStreamHandlerRuntime
Browse files Browse the repository at this point in the history
* uses reflection to access internal members of the java.net.URL class
* not used by default
* has lower performance than ModifiedSystemClassRuntime that is used by
  default and than SystemPropertiesRuntime
  • Loading branch information
Godin authored and marchof committed May 19, 2020
1 parent 1c5601b commit fea3a9f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 191 deletions.

This file was deleted.

This file was deleted.

6 changes: 6 additions & 0 deletions org.jacoco.doc/docroot/doc/changes.html
Expand Up @@ -54,6 +54,12 @@ <h3>Non-functional Changes</h3>
(GitHub <a href="https://github.com/jacoco/jacoco/issues/1032">#1032</a>).</li>
</ul>

<h3>API Changes</h3>
<ul>
<li><code>URLStreamHandlerRuntime</code> removed
(GitHub <a href="https://github.com/jacoco/jacoco/issues/471">#471</a>).</li>
</ul>

<h2>Release 0.8.5 (2019/10/11)</h2>

<h3>New Features</h3>
Expand Down
6 changes: 0 additions & 6 deletions org.jacoco.doc/docroot/doc/implementation.html
Expand Up @@ -200,12 +200,6 @@ <h2>Coverage Runtime Dependency</h2>
runtime registers a custom <code>Handler</code> to receive the parameter
array. This approach might break environments that install their own log
managers (e.g. Glassfish).</li>
<li><b><code>URLStreamHandlerRuntime</code></b>: This runtime registers a
<code>URLStreamHandler</code> for a "jacoco-xxxxx" protocol. Instrumented
classes open a connection on this protocol. The returned connection object
is the one that provides access to the coverage runtime through its
<code>equals()</code> method. However to register the protocol the runtime
needs to access internal members of the <code>java.net.URL</code> class.</li>
<li><b><code>ModifiedSystemClassRuntime</code></b>: This approach adds a
public static field to an existing JRE class through instrumentation. Unlike
the other methods above this is only possible for environments where a Java
Expand Down

0 comments on commit fea3a9f

Please sign in to comment.