Skip to content

Commit

Permalink
Use readable names for unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@marchof @Godin
marchof authored and Godin committed Sep 21, 2019
1 parent 8b586a9 commit 02682c9
Showing 1 changed file with 30 additions and 50 deletions.
80 changes: 30 additions & 50 deletions org.jacoco.report.test/src/org/jacoco/report/check/LimitTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,19 @@ public void setup() {
}

@Test
public void testDefaults() {
public void default_should_define_no_limits() {
assertNull(limit.getMinimum());
assertNull(limit.getMaximum());
}

@Test
public void default_should_check_coverageratio_on_instructions() {
assertEquals(CounterEntity.INSTRUCTION, limit.getEntity());
assertEquals(CounterValue.COVEREDRATIO, limit.getValue());
}

@Test
public void testTotalCount() {
public void check_should_fail_on_value_totalcount() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setMaximum("-1");
assertEquals(CounterValue.TOTALCOUNT, limit.getValue());
Expand All @@ -52,7 +56,7 @@ public void testTotalCount() {
}

@Test
public void testMissedCount() {
public void check_should_fail_on_value_missedcount() {
limit.setValue(CounterValue.MISSEDCOUNT.name());
limit.setMaximum("-1");
assertEquals(CounterValue.MISSEDCOUNT, limit.getValue());
Expand All @@ -62,7 +66,7 @@ public void testMissedCount() {
}

@Test
public void testCoveredCount() {
public void check_should_fail_on_value_coveredcount() {
limit.setValue(CounterValue.COVEREDCOUNT.name());
limit.setMaximum("-1");
assertEquals(CounterValue.COVEREDCOUNT, limit.getValue());
Expand All @@ -72,7 +76,7 @@ public void testCoveredCount() {
}

@Test
public void testMissedRatio() {
public void check_should_fail_on_value_missedratio() {
limit.setValue(CounterValue.MISSEDRATIO.name());
limit.setMaximum("-1");
assertEquals(CounterValue.MISSEDRATIO, limit.getValue());
Expand All @@ -86,7 +90,7 @@ public void testMissedRatio() {
}

@Test
public void testCoveredRatio() {
public void check_should_fail_on_value_coveredratio() {
limit.setValue(CounterValue.COVEREDRATIO.name());
limit.setMaximum("-1");
assertEquals(CounterValue.COVEREDRATIO, limit.getValue());
Expand All @@ -100,7 +104,7 @@ public void testCoveredRatio() {
}

@Test
public void testInstruction() {
public void check_should_fail_on_counter_instruction() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setCounter(CounterEntity.INSTRUCTION.name());
limit.setMaximum("-1");
Expand All @@ -111,7 +115,7 @@ public void testInstruction() {
}

@Test
public void testBranch() {
public void check_should_fail_on_check_counter_branch() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setCounter(CounterEntity.BRANCH.name());
limit.setMaximum("-1");
Expand All @@ -121,7 +125,7 @@ public void testBranch() {
}

@Test
public void testLine() {
public void check_should_fail_on_counter_line() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setCounter(CounterEntity.LINE.name());
limit.setMaximum("-1");
Expand All @@ -131,7 +135,7 @@ public void testLine() {
}

@Test
public void testComlexity() {
public void check_should_fail_on_counter_complexity() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setCounter(CounterEntity.COMPLEXITY.name());
limit.setMaximum("-1");
Expand All @@ -141,7 +145,7 @@ public void testComlexity() {
}

@Test
public void testClass() {
public void check_should_fail_on_counter_class() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setCounter(CounterEntity.CLASS.name());
limit.setMaximum("-1");
Expand All @@ -151,7 +155,7 @@ public void testClass() {
}

@Test
public void testMethod() {
public void check_should_fail_on_counter_method() {
limit.setValue(CounterValue.TOTALCOUNT.name());
limit.setCounter(CounterEntity.METHOD.name());
limit.setMaximum("-1");
Expand All @@ -161,7 +165,7 @@ public void testMethod() {
}

@Test
public void testNoRatio() {
public void check_should_pass_with_NaN_ratio() {
assertNull(limit.check(new TestNode() {
{
instructionCounter = CounterImpl.COUNTER_0_0;
Expand All @@ -170,7 +174,7 @@ public void testNoRatio() {
}

@Test
public void testNoLimits() {
public void check_should_pass_when_no_limits_given() {
assertNull(limit.check(new TestNode() {
{
instructionCounter = CounterImpl.getInstance(1000, 0);
Expand All @@ -179,14 +183,14 @@ public void testNoLimits() {
}

@Test
public void testMin0() {
public void setMinimum_should_allow_null() {
limit.setMinimum("0");
limit.setMinimum((String) null);
assertNull(limit.getMinimum());
}

@Test
public void testMin1() {
public void check_should_pass_when_minimum_is_fulfilled() {
limit.setMinimum("0.35");
assertEquals("0.35", limit.getMinimum());
assertNull(limit.check(new TestNode() {
Expand All @@ -197,18 +201,7 @@ public void testMin1() {
}

@Test
public void testMin2() {
limit.setMinimum("0.35");
assertEquals("0.35", limit.getMinimum());
assertNull(limit.check(new TestNode() {
{
instructionCounter = CounterImpl.getInstance(64, 36);
}
}));
}

@Test
public void testMin3() {
public void check_should_fail_when_minimum_is_not_met() {
limit.setMinimum("0.3500");
assertEquals("0.3500", limit.getMinimum());
assertEquals(
Expand All @@ -221,7 +214,7 @@ public void testMin3() {
}

@Test
public void testMin4() {
public void check_should_report_actual_ratio_rounded_down_when_minimum_is_not_met() {
limit.setMinimum("0.35");
assertEquals("0.35", limit.getMinimum());
assertEquals(
Expand All @@ -235,7 +228,7 @@ public void testMin4() {
}

@Test
public void testMin5() {
public void check_should_report_counter_with_given_precision() {
limit.setMinimum("10000");
limit.setValue(CounterValue.MISSEDCOUNT.name());
assertEquals("10000", limit.getMinimum());
Expand All @@ -249,20 +242,7 @@ public void testMin5() {
}

@Test
public void testMin6() {
limit.setMinimum("12345");
assertEquals("12345", limit.getMinimum());
assertEquals(
"instructions covered ratio is 0, but expected minimum is 12345",
limit.check(new TestNode() {
{
instructionCounter = CounterImpl.getInstance(1, 999);
}
}));
}

@Test
public void testMinPercent() {
public void setMinimum_should_accept_percentage_string() {
limit.setMinimum("1.55%");
assertEquals("0.0155", limit.getMinimum());

Expand All @@ -277,14 +257,14 @@ public void testMinPercent() {
}

@Test
public void testMax0() {
public void setMaximum_should_allow_null() {
limit.setMaximum("0");
limit.setMaximum((String) null);
assertNull(limit.getMaximum());
}

@Test
public void testMax1() {
public void check_should_pass_when_maximum_counter_is_fulfilled() {
limit.setMaximum("12345678");
limit.setValue(CounterValue.MISSEDCOUNT.name());
assertEquals("12345678", limit.getMaximum());
Expand All @@ -296,7 +276,7 @@ public void testMax1() {
}

@Test
public void testMax2() {
public void check_should_pass_when_maximum_ratio_is_fulfilled() {
limit.setMaximum("0.999");
assertEquals("0.999", limit.getMaximum());
assertNull(limit.check(new TestNode() {
Expand All @@ -307,7 +287,7 @@ public void testMax2() {
}

@Test
public void testMax3() {
public void check_should_fail_when_maximum_is_not_met() {
limit.setMaximum("0.999");
assertEquals("0.999", limit.getMaximum());
assertEquals(
Expand All @@ -320,7 +300,7 @@ public void testMax3() {
}

@Test
public void testMax4() {
public void check_should_report_actual_ratio_rounded_up_when_maximum_is_not_met() {
limit.setMaximum("0.999");
assertEquals("0.999", limit.getMaximum());
assertEquals(
Expand All @@ -334,7 +314,7 @@ public void testMax4() {
}

@Test
public void testMaxPercent() {
public void setMaximum_should_accept_percentage_string() {
limit.setMaximum("1.55%");
assertEquals("0.0155", limit.getMaximum());

Expand Down

0 comments on commit 02682c9

Please sign in to comment.