Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Giphy image/url parameter #203

Merged
merged 2 commits into from Feb 5, 2019
Merged

Fix Giphy image/url parameter #203

merged 2 commits into from Feb 5, 2019

Conversation

j0k3r
Copy link
Owner

@j0k3r j0k3r commented Feb 4, 2019

Also update deps

@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited

Coverage Status

Coverage increased (+0.009%) to 97.778% when pulling 9ea82ea on fix/giphy-image-url into dd212fe on master.

@j0k3r
Copy link
Owner Author

j0k3r commented Feb 5, 2019

Failure were related to symfony/symfony#29926

@j0k3r
Force default_protocol to generate an url input
9ea82ea 
It changed in Symfony 3.4.22 …
@j0k3r j0k3r merged commit ca3f6ba into master Feb 5, 2019
@j0k3r j0k3r deleted the fix/giphy-image-url branch February 5, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j0k3r @coveralls