Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.18 #171

Merged
merged 12 commits into from Mar 30, 2022
Merged

Go 1.18 #171

merged 12 commits into from Mar 30, 2022

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Mar 30, 2022

Summary

  • Changed to Go 1.18 in:
    • go.mod
    • GH actions
    • Dockerfile
    • README.md
  • Changed from interface{} to any
  • Changed to iver-wharf/swag fork for Swaggo (https://github.com/iver-wharf/swag) Fork removed.
  • Changed swaggo to v1.8.1 that supports Go 1.18.

Motivation

Swaggo doesn't support Go 1.18 yet (swaggo/swag#1162) but I found a fork that has fixed it for Go 1.18 (https://github.com/rdlaitila/swag).

Wondering why rdlaitila haven't opened a PR on this yet as their fix is allegedly 13 days old now.

As a temporary workaround, I forked rdlaitila's repo and merged in the latest swaggo changes, changed the Go module to github.com/iver-wharf/swag, and then released it at https://github.com/iver-wharf/swag/releases/tag/v1.8.1.

I'll watch the issue to see when we can remove our fork. Maybe will also spend time creating a PR to swaggo based on rdlaitila's changes.

Edit: They were quick to merge swaggo/swag#1168, so I changed to the new 1.8.1 version, and I've deleted our fork.

@applejag applejag added the chore Routine task, refactoring, or other changes not affecting end-users directly. label Mar 30, 2022
@applejag applejag self-assigned this Mar 30, 2022
Copy link
Member

@Alexamakans Alexamakans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@applejag applejag merged commit 038285f into master Mar 30, 2022
@applejag applejag deleted the feature/go-1.18 branch March 30, 2022 11:01
@applejag applejag mentioned this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Routine task, refactoring, or other changes not affecting end-users directly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants