fix: filterOption for transfer shouldn't depend on filterValue ant-de…

…sign#39906
ivan-tkatchev · Dec 30, 2022 · a7c49ee · a7c49ee
1 parent 5f40fe8
commit a7c49ee
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/components/transfer/__tests__/search.test.tsx b/components/transfer/__tests__/search.test.tsx
@@ -83,6 +83,6 @@ describe('Transfer.Search', () => {
 
     fireEvent.change(container.querySelector('.ant-input')!, { target: { value: ' ' } });
 
-    expect(filterOption).toHaveBeenCalledTimes(dataSource.length);
+    expect(filterOption).toHaveBeenCalledTimes(2*dataSource.length);
   });
 });
diff --git a/components/transfer/list.tsx b/components/transfer/list.tsx
@@ -115,6 +115,7 @@ export default class TransferList<
   getFilteredItems(
     dataSource: RecordType[],
     filterValue: string,
+    filterOption?: (filterText: string, item: RecordType) => boolean,
   ): { filteredItems: RecordType[]; filteredRenderItems: RenderedItem<RecordType>[] } {
     const filteredItems: RecordType[] = [];
     const filteredRenderItems: RenderedItem<RecordType>[] = [];
@@ -124,7 +125,7 @@ export default class TransferList<
       const { renderedText } = renderedItem;
 
       // Filter skip
-      if (filterValue && !this.matchFilter(renderedText, item)) {
+      if ((filterValue || filterOption) && !this.matchFilter(renderedText, item)) {
         return null;
       }
 
@@ -322,6 +323,7 @@ export default class TransferList<
       showRemove,
       pagination,
       direction,
+      filterOption,
     } = this.props;
 
     // Custom Layout
@@ -335,7 +337,7 @@ export default class TransferList<
 
     // ====================== Get filtered, checked item list ======================
 
-    const { filteredItems, filteredRenderItems } = this.getFilteredItems(dataSource, filterValue);
+    const { filteredItems, filteredRenderItems } = this.getFilteredItems(dataSource, filterValue, filterOption);
 
     // ================================= List Body =================================