Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GITHUB_TOKEN from release process #1115

Merged
merged 1 commit into from Apr 3, 2022
Merged

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Mar 29, 2022

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

This seems to be automatic now? It's no longer documented on https://github.com/softprops/action-gh-release/blob/fe9a9bd/README.md

Indeed it was removed in softprops/action-gh-release@7e3b173

@kousu kousu added the CI category: TravisCI, GitHub Actions, etc. label Mar 29, 2022
@kousu kousu requested a review from dyt811 March 29, 2022 21:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2061133478

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.163%

Totals Coverage Status
Change from base Build 2055018908: 0.0%
Covered Lines: 4673
Relevant Lines: 5903

💛 - Coveralls

@dyt811
Copy link
Member

dyt811 commented Apr 3, 2022

Looking good. Thanks for spotting this. I will make sure to double check this in the upcoming release to see if anything is affected. Shouldn't be as the original PR softprops/action-gh-release#83 mentioend but just in case.

Copy link
Member

@dyt811 dyt811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you like... find out about this lol? Is there a newsfeed or something I am missing. This sounds so very niche info. Super curious how you found out.

@dyt811 dyt811 merged commit b8232f5 into master Apr 3, 2022
@dyt811 dyt811 deleted the ng/release-drop-token branch April 3, 2022 15:55
@dyt811 dyt811 added this to the new release milestone Apr 6, 2022
cakester pushed a commit that referenced this pull request Apr 18, 2022
Now using default token automatically per PR83 from softprops/action-gh-release#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI category: TravisCI, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants