Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use custom elements manifest v1.0.0 #186

Merged
merged 11 commits into from
Jul 29, 2021

Conversation

Niznikr
Copy link
Collaborator

@Niznikr Niznikr commented Jul 26, 2021

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?

What does this change address?
Resolves #113

How does this change work?

  • Swap web-component-analyzer for @custom-elements-manifest/analyzer
  • Update Storybook to support the updated format
  • Update React build script

on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2021

🦋 Changeset detected

Latest commit: 0345802

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

on-behalf-of: @ithaka <robert.niznik@ithaka.org>
@Niznikr Niznikr removed the request for review from a team July 26, 2021 15:48
@Niznikr
Copy link
Collaborator Author

Niznikr commented Jul 29, 2021

Initially blocked by open-wc/custom-elements-manifest#83 and open-wc/custom-elements-manifest#102. Able to move forward with a custom plugin and additional logic in the React build script.

@Niznikr Niznikr merged commit 3946ca2 into develop Jul 29, 2021
@Niznikr Niznikr deleted the feat/custom-elements-manifest branch July 29, 2021 18:41
@github-actions github-actions bot mentioned this pull request Aug 11, 2021
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
on-behalf-of: @ithaka <robert.niznik@ithaka.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra: Use Custom Elements Manifest v1.0.0
2 participants