Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Use Custom Elements Manifest v1.0.0 #113

Closed
Tracked by #47
Niznikr opened this issue Jun 17, 2021 · 0 comments · Fixed by #186
Closed
Tracked by #47

Infra: Use Custom Elements Manifest v1.0.0 #113

Niznikr opened this issue Jun 17, 2021 · 0 comments · Fixed by #186

Comments

@Niznikr
Copy link
Collaborator

Niznikr commented Jun 17, 2021

The problem
Custom Elements Manifest is a file format that describes custom elements in a project. It allows tooling and IDEs to give users information about those elements when used in their project. We have been working with the experimental version generated by web-component-analyzer. The spec has now been standardized.

The solution

  • Use @custom-elements-manifest/analyzer to generate our custom-elements.json
  • Update to a Storybook version that supports the new spec
  • Update the React gulp task to parse the new format correctly to generate the TS interface

Alternatives considered
NA

Additional information
storybookjs/storybook#15138

@Niznikr Niznikr self-assigned this Jun 30, 2021
@daneah daneah changed the title Use Custom Elements Manifest v1.0.0 Infra: Use Custom Elements Manifest v1.0.0 Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants