Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract load_path function from common code using LOADERS #7983

Merged
merged 2 commits into from Aug 9, 2022

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Jul 6, 2022

Following up on #7965 (comment)

@alexmojaki alexmojaki requested a review from a team as a code owner July 6, 2022 19:40
@karajan1001 karajan1001 requested a review from daavoo July 7, 2022 09:48
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexmojaki !
Could you squash the commits into 1?

@daavoo daavoo enabled auto-merge (rebase) August 9, 2022 07:05
@daavoo daavoo removed the request for review from karajan1001 August 9, 2022 07:05
@daavoo daavoo disabled auto-merge August 9, 2022 07:06
@daavoo daavoo enabled auto-merge (squash) August 9, 2022 08:56
@daavoo daavoo merged commit 2ca1d6c into iterative:main Aug 9, 2022
@pmrowla pmrowla added refactoring Factoring and re-factoring maintenance labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance refactoring Factoring and re-factoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants