Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude pylint==6.0 #4300

Merged
merged 1 commit into from Jul 29, 2020
Merged

Exclude pylint==6.0 #4300

merged 1 commit into from Jul 29, 2020

Conversation

skshetry
Copy link
Member

pytest-dev/pytest#7558
pylint throws error for pytest.mark.* functions in pytest6.

tests/unit/repo/test_repo.py:15:1: E1102: pytest.mark.parametrize is not callable (not-callable)
tests/unit/repo/test_repo.py:33:1: E1102: pytest.mark.parametrize is not callable (not-callable)
************* Module tests.unit.remote.ssh.test_connection
tests/unit/remote/ssh/test_connection.py:87:1: E1102: pytest.mark.skipif is not callable (not-callable)
tests/unit/remote/ssh/test_connection.py:100:1: E1102: pytest.mark.skipif is not callable (not-callable)

#4257 (comment)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

pytest-dev/pytest#7558
pylint throws error for `pytest.mark.*` functions in pytest6.

```
tests/unit/repo/test_repo.py:15:1: E1102: pytest.mark.parametrize is not callable (not-callable)
tests/unit/repo/test_repo.py:33:1: E1102: pytest.mark.parametrize is not callable (not-callable)
************* Module tests.unit.remote.ssh.test_connection
tests/unit/remote/ssh/test_connection.py:87:1: E1102: pytest.mark.skipif is not callable (not-callable)
tests/unit/remote/ssh/test_connection.py:100:1: E1102: pytest.mark.skipif is not callable (not-callable)
```
#4257 (comment)
@skshetry skshetry added the build Issues/features related to building dvc install packages. label Jul 29, 2020
@skshetry skshetry self-assigned this Jul 29, 2020
@skshetry skshetry added this to In progress in DVC 28 July - 11 August 2020 via automation Jul 29, 2020
@skshetry
Copy link
Member Author

We need to fix our dependencies for the tests, and auto-update them with dependabot.

@skshetry skshetry moved this from In progress to Review in progress in DVC 28 July - 11 August 2020 Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #4300 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4300   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         173      173           
  Lines       11776    11776           
=======================================
  Hits        10793    10793           
  Misses        983      983           
Impacted Files Coverage Δ
dvc/version.py 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31efaac...abf6943. Read the comment docs.

@skshetry skshetry merged commit 9ca3c05 into master Jul 29, 2020
DVC 28 July - 11 August 2020 automation moved this from Review in progress to Done Jul 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the skshetry-patch-1 branch July 29, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues/features related to building dvc install packages.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant