Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progressbar cleanup #2436

Merged
merged 15 commits into from Aug 29, 2019
Merged

progressbar cleanup #2436

merged 15 commits into from Aug 29, 2019

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Aug 25, 2019

Post-merge of #2333, sort out a few issues (both new and pre-existing)

  • custom default bar_format
    • fix bar width (specify bar width format-spec tqdm/tqdm#623)
    • truncate and/or justify file names (right align? max truncation len? prefix ellipsis? multi-line (multiline progress bar tqdm/tqdm#630)?) description (from right) to fit into terminal width
      • remove progress.Tqdm.truncate
      • remove progress.Tqdm.__init__(desc_truncate)
      • remove progress.Tqdm.update_desc(truncate)
    • still auto-detect ncols (fill space with whitespace rather than variable bar width?)
      • add progress.Tqdm.format_dict["ncols_desc"]
  • make progressbars less verbose
    • add level=INFO (when disable=None)
    • add leave_level=DEBUG (when leave=None) add leave=False
  • demote other messages info -> debug
  • make progress.Tqdm.desc persistent
    • get rid of progress.Tqdm.update_desc("", 0)
    • get rid of progress.Tqdm.set_description_str()
  • depends on next release - update inheritance, multiprocessing examples, bar_format without total tqdm/tqdm#800
  • include the name of the remote into cache_exists bar
      • bar descriptions such as Querying cache in .dvc/cache and Querying cache in s3://mybucket/mypath
  • replace md5?
  • remove all output (incl. Checkout progress bar)
  • fixes progressbar cleanup #2434

asciicast

@casperdcl casperdcl added the ui user interface / interaction label Aug 25, 2019
@casperdcl casperdcl requested a review from efiop August 25, 2019 00:21
@casperdcl casperdcl self-assigned this Aug 25, 2019
@casperdcl casperdcl added the enhancement Enhances DVC label Aug 25, 2019
@casperdcl
Copy link
Contributor Author

casperdcl commented Aug 25, 2019

@efiop I had to release a new version of tqdm (again!) so note that the conda-recipie would also have to be updated

@efiop
Copy link
Member

efiop commented Aug 25, 2019

@casperdcl Great news 🙂 Btw, tests failed on travis 🙁

@casperdcl
Copy link
Contributor Author

@efiop argh going to need another tqdm release. Depends on tqdm/tqdm#800 (tqdm/tqdm@5d373de).

dvc/progress.py Outdated Show resolved Hide resolved
dvc/remote/ssh/__init__.py Outdated Show resolved Hide resolved
dvc/progress.py Outdated Show resolved Hide resolved
dvc/progress.py Outdated Show resolved Hide resolved
dvc/progress.py Outdated Show resolved Hide resolved
dvc/remote/local/__init__.py Show resolved Hide resolved
dvc/progress.py Outdated Show resolved Hide resolved
@casperdcl casperdcl requested review from efiop and Suor August 27, 2019 19:46
Copy link
Contributor

@Suor Suor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing - can we show desc on top of the bar? Inversing fore/back when it's filled over. This will allow make both longer.

If that is possible it could be done in a separate PR, since this one is almost ready, no point in delaying it.

dvc/progress.py Outdated Show resolved Hide resolved
dvc/progress.py Show resolved Hide resolved
@casperdcl
Copy link
Contributor Author

casperdcl commented Aug 28, 2019

@Suor

Another thing - can we show desc on top of the bar? Inversing fore/back when it's filled over. This will allow make both longer.

If that is possible it could be done in a separate PR, since this one is almost ready, no point in delaying it.

feel free to open a new issue and assign me :)

Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@efiop efiop merged commit 1ed3645 into iterative:master Aug 29, 2019
@casperdcl casperdcl deleted the ui-tidy branch September 12, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

progressbar cleanup
3 participants