Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attrs explicit dependency #10354

Merged
merged 1 commit into from Mar 16, 2024
Merged

add attrs explicit dependency #10354

merged 1 commit into from Mar 16, 2024

Conversation

shcheklein
Copy link
Member

fixes AttrsInstance import failing on older versions of attrs, fixed by python-attrs/attrs#987

TODO:

  • Update conda package.
  • Do we update other places (other packages in some way)?

fixes AttrsInstance import failing, fixed by python-attrs/attrs#987
@shcheklein shcheklein added bug Did we break something? dependencies Pull requests that update a dependency file labels Mar 15, 2024
@shcheklein shcheklein self-assigned this Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (a80d224) to head (615ee06).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10354   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files         500      500           
  Lines       38696    38696           
  Branches     5600     5600           
=======================================
  Hits        35088    35088           
  Misses       2961     2961           
  Partials      647      647           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skshetry skshetry merged commit 017a510 into main Mar 16, 2024
20 checks passed
@skshetry skshetry deleted the fix-attrs-dep branch March 16, 2024 03:13
@shcheklein
Copy link
Member Author

@skshetry

  • Update conda package.
  • Do we update other places (other packages in some way)?

what is the policy about those?

@skshetry
Copy link
Member

We can update the conda package today without waiting for a new release (we need to add attrs as a dependency and increment the build number). But AttrsInstance is only used in ds command which is not released yet, so it's not urgent. But we don't actively update conda packages, as most users will get new versions of dependency anyway (we haven't had any complaints so far).

There are no other places that we need to add.

shcheklein added a commit to shcheklein/dvc-feedstock that referenced this pull request Mar 16, 2024
shcheklein added a commit to shcheklein/dvc-feedstock that referenced this pull request Mar 16, 2024
BradyJ27 pushed a commit to BradyJ27/dvc that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants