New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc plots: allow for setting output directory via config #7911
dvc plots: allow for setting output directory via config #7911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor things related to tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PΜΆeΜΆrΜΆhΜΆaΜΆpΜΆsΜΆ ΜΆIΜΆ ΜΆaΜΆmΜΆ ΜΆoΜΆvΜΆeΜΆrΜΆtΜΆhΜΆiΜΆnΜΆkΜΆiΜΆnΜΆgΜΆ ΜΆaΜΆnΜΆdΜΆ ΜΆiΜΆtΜΆ'ΜΆsΜΆ ΜΆjΜΆuΜΆsΜΆtΜΆ ΜΆaΜΆ ΜΆmΜΆaΜΆtΜΆtΜΆeΜΆrΜΆ ΜΆoΜΆfΜΆ ΜΆaΜΆdΜΆdΜΆiΜΆnΜΆgΜΆ ΜΆeΜΆxΜΆaΜΆmΜΆpΜΆlΜΆeΜΆsΜΆ ΜΆiΜΆnΜΆ ΜΆdΜΆoΜΆcΜΆsΜΆ.ΜΆ ΜΆSΜΆtΜΆiΜΆlΜΆlΜΆ,ΜΆ ΜΆwΜΆeΜΆ ΜΆaΜΆlΜΆlΜΆoΜΆwΜΆ ΜΆsΜΆtΜΆoΜΆrΜΆiΜΆnΜΆgΜΆ ΜΆaΜΆnΜΆ ΜΆuΜΆnΜΆrΜΆeΜΆsΜΆoΜΆlΜΆvΜΆeΜΆdΜΆ ΜΆpΜΆaΜΆtΜΆhΜΆ ΜΆiΜΆnΜΆ ΜΆΜΆ.ΜΆdΜΆvΜΆcΜΆ/ΜΆcΜΆoΜΆnΜΆfΜΆiΜΆgΜΆ
ΜΆ ΜΆsΜΆoΜΆ ΜΆuΜΆsΜΆeΜΆrΜΆsΜΆ ΜΆcΜΆaΜΆlΜΆlΜΆiΜΆnΜΆgΜΆ ΜΆfΜΆrΜΆoΜΆmΜΆ ΜΆdΜΆiΜΆfΜΆfΜΆeΜΆrΜΆeΜΆnΜΆtΜΆ ΜΆCΜΆWΜΆDΜΆ ΜΆwΜΆiΜΆlΜΆlΜΆ ΜΆsΜΆaΜΆvΜΆeΜΆ ΜΆpΜΆlΜΆoΜΆtΜΆsΜΆ ΜΆtΜΆoΜΆ ΜΆdΜΆiΜΆfΜΆfΜΆeΜΆrΜΆeΜΆnΜΆtΜΆ ΜΆfΜΆoΜΆlΜΆdΜΆeΜΆrΜΆsΜΆ.ΜΆ
Looks like we already do this for other path config options (i.e. html template path)
5495e3b
to
a38d9e1
Compare
0b80e8f
to
1d98b9b
Compare
All done. π |
* config: Add `plots.out_dir`. Per iterative/dvc#7911 * Update content/docs/command-reference/config.md * Restyled by prettier (#3760) Co-authored-by: Restyled.io <commits@restyled.io> * Updates * Format * Apply suggestions from code review Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
[x ] β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
This PR allows users to set output directory for
dvc plots show
viadvc config
. I added a test covering this scenario.To test run the following script: