Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc plots show: Allow for setting output directory via config or dvc.yaml #7816

Closed
mseflek opened this issue May 26, 2022 · 4 comments · Fixed by #7911
Closed

dvc plots show: Allow for setting output directory via config or dvc.yaml #7816

mseflek opened this issue May 26, 2022 · 4 comments · Fixed by #7911
Labels
A: plots Related to the plots feature request Requesting a new feature good first issue

Comments

@mseflek
Copy link

mseflek commented May 26, 2022

Currently the output directory (default dvc_plots/) for the HTML file produced by dvc plots show can only be defined via the command's -o flag. It would be great if it could be set via dvc.yaml or the config files so that running dvc plots show automatically saves the file in a predefined place. This would make it more seamless to use in projects with a well-defined directory structure.

@daavoo daavoo added A: plots Related to the plots feature request Requesting a new feature labels May 27, 2022
@dberenbaum
Copy link
Contributor

@pared @daavoo How hard do you think this would be? Would it make a good first issue?

@daavoo
Copy link
Contributor

daavoo commented Jun 6, 2022

@pared @daavoo How hard do you think this would be?

I think not much, but probably there are some gotchas.

Would it make a good first issue?

Maybe not, because of the gotchas.

@pared
Copy link
Contributor

pared commented Jun 6, 2022

I don't see any bigger problems at first sight. We already have a config section for plots, there is only one actual line addressing dvc_plots, in plots command code. We can access the repo there too... there might be a problem with no repo situation, but AFAIR getting config there will result in an empty dict.

@pared
Copy link
Contributor

pared commented Jun 6, 2022

I would consider it for first issue.

ykasimov pushed a commit to ykasimov/dvc that referenced this issue Jun 20, 2022
@daavoo daavoo linked a pull request Jun 20, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots feature request Requesting a new feature good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants