build(deps): Unpin networkx; quote node names for pydot output #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [networkx](https://github.com/networkx/networkx) to permit the latest version. - [Release notes](https://github.com/networkx/networkx/releases) - [Commits](networkx/networkx@networkx-2.5...networkx-2.8.4) --- updated-dependencies: - dependency-name: networkx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Note that |
skshetry
changed the title
skshetry
reviewed
Jun 15, 2022
Comment on lines
-148
to
-153
| "stage;", | ||
| "stage;", | ||
| "stage;", | ||
| "stage;", | ||
| "stage;", | ||
| "stage;", |
There was a problem hiding this comment.
This one was a bug in escaping. Should be fixed by quoting node names.
|
Thank you! 🙏 |
daavoo
reviewed
Jun 15, 2022
| @@ -117,7 +117,7 @@ def test_import_url_to_remote(mocker): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_import_url_to_remote_invalid_combination(mocker, caplog): | |||
| def test_import_url_to_remote_invalid_combination(dvc, mocker, caplog): | |||
There was a problem hiding this comment.
I was getting LockError with the VSCode extension running in the background, adding dvc fixture isolates the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on networkx to permit the latest version.
Release notes
Sourced from networkx's releases.
Commits
b894696Designate 2.8.4 releaseea424ebAdd 2.8.4 release notes00cd32cCI: add pytest-randomly workflow. (#4553)304682fAdd example of topo_order kwarg to dag_longest_path (#5728)ec267cfAdd PendingDeprecation for pydot (#5721)6abae05Touchups to MG and MDG edges docstrings. (#5708)6a71423Update doc requirements (#5711)23fc756Recover order of layers in multipartite_layout when layers are sortable (#5705)4e92d77Add durations flag to coverage run on CI. (#5718)11f338bSome more changes to make pytest-randomly happy (#5719)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)