Skip to content

Commit

Permalink
ui: fix missing progress & tidy (#3335)
Browse files Browse the repository at this point in the history
* ui: show missing progress

Fixes #3332

* ui: more verbose progress

* remote: base: back to no_progres_bar=True
  • Loading branch information
casperdcl committed Feb 19, 2020
1 parent 6dba652 commit 37de65f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion dvc/remote/gdrive.py
Expand Up @@ -246,7 +246,7 @@ def gdrive_upload_file(
self,
parent_id,
title,
no_progress_bar=True,
no_progress_bar=False,
from_file="",
progress_name="",
):
Expand Down
6 changes: 3 additions & 3 deletions dvc/remote/gs.py
Expand Up @@ -51,7 +51,7 @@ def _upload_to_bucket(
to_info,
chunk_size=None,
name=None,
no_progress_bar=True,
no_progress_bar=False,
):
blob = bucket.blob(to_info.path, chunk_size=chunk_size)
with io.open(from_file, mode="rb") as fobj:
Expand Down Expand Up @@ -166,7 +166,7 @@ def exists(self, path_info):
"""
return self.isfile(path_info) or self.isdir(path_info)

def _upload(self, from_file, to_info, name=None, no_progress_bar=True):
def _upload(self, from_file, to_info, name=None, no_progress_bar=False):
bucket = self.gs.bucket(to_info.bucket)
_upload_to_bucket(
bucket,
Expand All @@ -176,7 +176,7 @@ def _upload(self, from_file, to_info, name=None, no_progress_bar=True):
no_progress_bar=no_progress_bar,
)

def _download(self, from_info, to_file, name=None, no_progress_bar=True):
def _download(self, from_info, to_file, name=None, no_progress_bar=False):
bucket = self.gs.bucket(from_info.bucket)
blob = bucket.get_blob(from_info.path)
with io.open(to_file, mode="wb") as fobj:
Expand Down

0 comments on commit 37de65f

Please sign in to comment.