Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydra: updates to config composition info. #4041

Merged
merged 9 commits into from
Nov 8, 2022
Merged

Hydra: updates to config composition info. #4041

merged 9 commits into from
Nov 8, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Oct 13, 2022 •
edited

@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference labels Oct 13, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-hydra-comp-bbprg0ujtfg October 13, 2022 02:53 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022 •
edited

daa7f03

Link Check Report

  • content/docs/user-guide/experiment-management/hydra-composition.md
    • yaml = https://yaml/ (Site not found)

1/28 links failed.

CML watermark

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 13, 2022 •
edited 

*   content/docs/user-guide/experiment-management/hydra-composition.md
   *   `yaml = https://`yaml/ (Site not found)

1/28 links failed.

Hi @iterative/websites 👋🏼 any idea where this comes from? Seems like a regexp 🐞 to me (see src).

U: Ah yeah, I think it's from

... [defaults list]:

```yaml

So the regexp should not match ref links with an empty line between : and the URL.

U2: Created iterative/link-check#28

@jorgeorpinel jorgeorpinel mentioned this pull request Oct 13, 2022
Closed
1 task
@yathomasi yathomasi temporarily deployed to dvc-org-hydra-comp-bbprg0ujtfg October 14, 2022 13:12 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-hydra-comp-bbprg0ujtfg October 15, 2022 00:25 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review October 15, 2022 00:25
@jorgeorpinel jorgeorpinel added the type: enhancement Something is not clear, small updates, improvement suggestions label Nov 4, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-hydra-comp-bbprg0ujtfg November 4, 2022 06:02 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-hydra-comp-bbprg0ujtfg November 4, 2022 06:03 Inactive
@jorgeorpinel
Copy link
Contributor Author

Some of these updates should improve on feedback from @mnrozhkov (or my interpretation: that it needs more links from other docs).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022 •
edited

7d97932

Link Check Report

There were no links to check!

dberenbaum
dberenbaum approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but nothing blocking. Thanks @jorgeorpinel!

@jorgeorpinel jorgeorpinel mentioned this pull request Nov 8, 2022
Closed
@shcheklein shcheklein temporarily deployed to dvc-org-hydra-comp-bbprg0ujtfg November 8, 2022 17:31 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Nov 8, 2022 •
edited

Idk why the review app is 404ing. I fixed some bad links in f4e086b but otherwise they all work locally for me. Merging!

@jorgeorpinel jorgeorpinel merged commit 7d97932 into main Nov 8, 2022
@jorgeorpinel jorgeorpinel deleted the hydra-comp branch November 8, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

@daavoo daavoo daavoo approved these changes

Assignees
No one assigned
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jorgeorpinel @dberenbaum @daavoo @shcheklein @yathomasi