-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exp init
: UX updates
#3430
Merged
Merged
exp init
: UX updates
#3430
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cc0457b
document exp init output changes
skshetry 7682de2
Apply suggestions from code review
jorgeorpinel 70e1866
Restyled by prettier (#3439)
restyled-io[bot] 35a4074
Merge branch 'master' into document-exp-init-changes
jorgeorpinel 5b79b0f
ref: update exp init -i samples
jorgeorpinel 78b98df
Merge branch 'master' into document-exp-init-changes
jorgeorpinel c296e6b
ref: clarify when `exp init` creates boilerplate struct and
jorgeorpinel 925e6ef
Update content/docs/command-reference/exp/init.md
jorgeorpinel 610c08d
Merge branch 'master' into document-exp-init-changes
jorgeorpinel a5103c8
Merge branch 'document-exp-init-changes' of github.com:iterative/dvc.…
jorgeorpinel cac037a
ref: exp init now creates dirs for outs
jorgeorpinel eee3d71
Merge branch 'master' into document-exp-init-changes
jorgeorpinel 605a1c0
Update content/docs/command-reference/exp/init.md
jorgeorpinel File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be in a separate PR, but we should probably use
predict.h5
ormodel.h5
instead ofmodels/predict.h5
until iterative/dvc#5802 is resolved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. a) it's a bug I think (shouldn't doc based on that) and b) the output of
exp init
does sayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have clarified. This is what happens now:
Yeah, we need to prioritize fixing this in DVC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K. Marking this PR with
wait
status. Please lmk when to follow up if possible!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel This is finally ready following iterative/dvc#7752.