Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove fixtures, use pytest-servers #89

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jul 4, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #89 (010cdfb) into main (010cdfb) will not change coverage.
The diff coverage is n/a.

❗ Current head 010cdfb differs from pull request most recent head eb476cb. Consider uploading reports for the commit eb476cb to get more accurate results

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   34.32%   34.32%           
=======================================
  Files          33       33           
  Lines        1681     1681           
  Branches      302      302           
=======================================
  Hits          577      577           
  Misses       1091     1091           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010cdfb...eb476cb. Read the comment docs.

@efiop
Copy link
Member

efiop commented Jul 4, 2022

@dtrifiro Looks like s3 fixture is still randomly failing. Could you take a look, please?

@dtrifiro

This comment was marked as outdated.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jul 6, 2022

Seems universal pathlib is broken on 3.11, see fsspec/universal_pathlib#67

@dtrifiro
Copy link
Contributor Author

Waiting on #98

@efiop
Copy link
Member

efiop commented Jul 11, 2022

@dtrifiro Please rebase.

EDIT: ah, nevermind

@efiop efiop merged commit 89ddeaf into iterative:main Jul 11, 2022
@dtrifiro dtrifiro deleted the use-pytest-servers branch July 11, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants