Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide cml runner --tpi-version #967

Merged
merged 2 commits into from Apr 16, 2022
Merged

Hide cml runner --tpi-version #967

merged 2 commits into from Apr 16, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 16, 2022 •
edited

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 16, 2022 09:06 Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 16, 2022
@0x2b3bfa0 0x2b3bfa0 added the cml-runner Subcommand label Apr 16, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 16, 2022
Merged
casperdcl
casperdcl previously approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beats documenting --flag<SPACE>=<THING>

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 16, 2022 09:19 Inactive
@casperdcl casperdcl enabled auto-merge (squash) April 16, 2022 09:20
@0x2b3bfa0
Copy link
Member Author

beats documenting --flag<SPACE>=<THING>

Do you mean --flag="<THING><SPACE>" as per #852 (comment)? 😅

@casperdcl
Copy link
Contributor

casperdcl commented Apr 16, 2022 •
edited

No I mean equally bad lawful evil

@casperdcl casperdcl merged commit dc27724 into master Apr 16, 2022
@casperdcl casperdcl deleted the hide-cml-runner-tpi-version branch April 16, 2022 09:32
@0x2b3bfa0

This comment was marked as off-topic.

Sign in to view
@dacbd
Copy link
Contributor

dacbd commented Apr 16, 2022

🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cml-runner Subcommand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x2b3bfa0 @casperdcl @dacbd