Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: remove from menu, update in docs (nav and content) #447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jorgeorpinel
Copy link
Contributor

Re-do of #381

I think it's confusing to promote the idea of direct installation for CML since it's not the happy path, so I'm proposing to clarifying that in the docs, and to remove the big menu button. Other notes for review below...

See more details starting in #381 (review) .

moving nav entry before Cmd Ref and clarifying/simplifying the page as well
@jorgeorpinel jorgeorpinel added documentation Markdown files A: website Area: website labels Feb 23, 2023
@jorgeorpinel jorgeorpinel requested a review from a team as a code owner February 23, 2023 07:22
@shcheklein shcheklein temporarily deployed to cml-dev-nav-menu-ajycenfwzdjjb February 23, 2023 07:23 Inactive
Comment on lines 2 to 3
import { Flex, Box, Container, Button } from '@theme-ui/components'
import InstallPopup from '../../../../components/molecules/InstallPopup'
import SmartLink from '../../../../components/atoms/SmartLink'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is the right repo to edit this file now though.

@github-actions
Copy link

Link Check Report

All 4 links passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website documentation Markdown files stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants