feat: implement entity field in /{software/,}logs #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfabio
force-pushed
the
entity-logs
branch
3 times, most recently
from
a5bd85a
to
a9fdd39
Compare
|
The test failing looks like a gorm bug 🤔 Gotta investigate it. |
|
Tests fail when using PostgreSQL as backend as well |
|
Ok confirming as a gorm bug. Looks like it's this one go-gorm/gorm#5417, fixed in recent releases |
|
@LorenzoS92 fixed, ready for review |
LorenzoS92
approved these changes
Nov 6, 2022
| EntityType string `json:"-"` | ||
| EntityID *string `json:"-"` | ||
| EntityType *string `json:"-"` | ||
| Entity string `json:"entity,omitempty" gorm:"->;type:text GENERATED ALWAYS AS (CASE WHEN entity_id IS NULL THEN NULL ELSE ('/' || entity_type || '/' || entity_id) END) STORED;default:(-);"` //nolint:lll |
There was a problem hiding this comment.
Curioso quel simbolo dentro gorm, cosa serve?
There was a problem hiding this comment.
@LorenzoS92 it specifies permissions for that field, in that case we set it read only since it's a automatically generated field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.