Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better-behaved HBONE pooling #931

Merged
merged 46 commits into from
Apr 26, 2024
Merged

Better-behaved HBONE pooling #931

merged 46 commits into from
Apr 26, 2024

Commits on Apr 26, 2024

  1. Attempt at smarter HBONE pooling between ztunnels 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c7ec54e View commit details
    Browse the repository at this point in the history

  2. Lints 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    af0d232 View commit details
    Browse the repository at this point in the history

  3. lints 2 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    58e7ab9 View commit details
    Browse the repository at this point in the history

  4. Hmm 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5f8e182 View commit details
    Browse the repository at this point in the history

  5. Fixup 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a585659 View commit details
    Browse the repository at this point in the history

  6. Fixup 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    05e3401 View commit details
    Browse the repository at this point in the history

  7. More comments 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2a2fa32 View commit details
    Browse the repository at this point in the history

  8. cleanup 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    add0dce View commit details
    Browse the repository at this point in the history

  9. fixup 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b290040 View commit details
    Browse the repository at this point in the history

  10. Clean 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    17de2be View commit details
    Browse the repository at this point in the history

  11. Fix jemalloc 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6ebfc30 View commit details
    Browse the repository at this point in the history

  12. WIP: move out of proxyinfo 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ed2a284 View commit details
    Browse the repository at this point in the history

  13. Evict pooled conns after $INTERVAL 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5abf00f View commit details
    Browse the repository at this point in the history

  14. Update src/proxy/pool.rs 

    Co-authored-by: Ian Rudie <ilrudie@gmail.com>
    @bleggett @ilrudie
    bleggett and ilrudie committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    86d458c View commit details
    Browse the repository at this point in the history

  15. Evict pooled conns after $INTERVAL 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    417ee87 View commit details
    Browse the repository at this point in the history

  16. For now, just do the foolproof collision check 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    996ac4b View commit details
    Browse the repository at this point in the history

  17. Don't be silly 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c413650 View commit details
    Browse the repository at this point in the history

  18. Naming, review comments 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    cf6b7c1 View commit details
    Browse the repository at this point in the history

  19. Tidy Arcs+drains 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    036a2e6 View commit details
    Browse the repository at this point in the history

  20. Cleanups 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b04e5e9 View commit details
    Browse the repository at this point in the history

  21. Format 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    53e790a View commit details
    Browse the repository at this point in the history

  22. Use the fancy lockless outer map, drop realm-io 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6be0b55 View commit details
    Browse the repository at this point in the history

  23. Cleanup comments 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b461cf3 View commit details
    Browse the repository at this point in the history

  24. Fix outdent (review comment) 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d4b4d30 View commit details
    Browse the repository at this point in the history

  25. Fixups/review comments 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fe5ea2c View commit details
    Browse the repository at this point in the history

  26. resync 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6ff22cc View commit details
    Browse the repository at this point in the history

  27. Droptests 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2025a0f View commit details
    Browse the repository at this point in the history

  28. fix testhang 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4a0dc47 View commit details
    Browse the repository at this point in the history

  29. add smarter evict test 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    852100c View commit details
    Browse the repository at this point in the history

  30. Interesting failure 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    45f23ac View commit details
    Browse the repository at this point in the history

  31. No, it's not 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9ec19b2 View commit details
    Browse the repository at this point in the history

  32. Make this a bit simpler 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c2f9015 View commit details
    Browse the repository at this point in the history

  33. Separate out the connspawner 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bde5b45 View commit details
    Browse the repository at this point in the history

  34. Tidy logging a bit 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    22840ae View commit details
    Browse the repository at this point in the history

  35. Add serverside keepalive 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f1b102a View commit details
    Browse the repository at this point in the history

  36. fixup 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    795b4ae View commit details
    Browse the repository at this point in the history

  37. Just for kicks 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e16368a View commit details
    Browse the repository at this point in the history

  38. D'oh - use mthread runtime for tests 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    969b99a View commit details
    Browse the repository at this point in the history

  39. Fix none race 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bdb1c86 View commit details
    Browse the repository at this point in the history

  40. Propagate connection establish errors 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bd2ca75 View commit details
    Browse the repository at this point in the history

  41. Cleanup 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fb872fd View commit details
    Browse the repository at this point in the history

  42. Work around local test server getting overloaded 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3105377 View commit details
    Browse the repository at this point in the history

  43. Move the rest to multi_thread, chill out on iterations, work around test 

    rig flakes

Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e713b17 View commit details
    Browse the repository at this point in the history

  44. Tidy comments 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4495fc2 View commit details
    Browse the repository at this point in the history

  45. lints 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7e794b6 View commit details
    Browse the repository at this point in the history

  46. Clarify comment 

    Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
    @bleggett
    bleggett committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8737cd7 View commit details
    Browse the repository at this point in the history