Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix CNI Version Skew test #50969

Merged
merged 1 commit into from May 13, 2024

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn requested a review from a team as a code owner May 9, 2024 20:53
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 9, 2024
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2024
@bleggett
Copy link
Contributor

bleggett commented May 9, 2024

https://prow.istio.io/view/gs/istio-prow/logs/integ-cni_istio_postsubmit/1788646342856282112

(should we be testing CNI from 1.11 "N-1"? Probably not)

Didn't know we had a test for this.

We should have this for ambient as well, where it arguably matters more.

@howardjohn
Copy link
Member Author

@bleggett mind reviewing? postsubmit is broken without this

@bleggett
Copy link
Contributor

@bleggett mind reviewing? postsubmit is broken without this

Thought I had, apparently not.

@istio-testing istio-testing merged commit 51b1876 into istio:master May 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants