do not add previous hosts predicate when consistent hashing is enabled #50759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-policy-bot
added
the
release-notes-none
istio-testing
added
the
size/M
hzxuzhonghu
reviewed
May 6, 2024
| @@ -73,7 +90,6 @@ func ConvertPolicy(in *networking.HTTPRetry) *route.RetryPolicy { | |||
| } | |||
|
|
|||
| // A policy was specified. Start with the default and override with user-provided fields where appropriate. | |||
| out := DefaultPolicy() | |||
There was a problem hiding this comment.
donot we need to distinguish hash here
There was a problem hiding this comment.
it is moved up and handle both cases
hzxuzhonghu
reviewed
May 6, 2024
| if len(in.Route) == 1 { | ||
| hostnames = append(hostnames, processDestination(in.Route[0], serviceRegistry, listenerPort, hashByDestination, out, action)) | ||
| hash := hashByDestination[in.Route[0]] | ||
| consistentHash = hash != nil |
There was a problem hiding this comment.
How do you handle consitent hash for the below else branch
There was a problem hiding this comment.
consistent hash and weighted desitnations do not work together
There was a problem hiding this comment.
do we have validation that checked it
There was a problem hiding this comment.
I do not think we have - but we should add IMO (atleast warn)
|
@hzxuzhonghu can you PTAL when you get chance? |
|
@howardjohn @hzxuzhonghu Can you PTAL when you get chance? |
|
@hzxuzhonghu Can you PTAL when you get chance? |
howardjohn
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50756