New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump foreground-child from ^2.0.0 to ^3.0.0 #1546
base: main
Are you sure you want to change the base?
Conversation
@nwalters512 do you need to run
|
@bcoe can you say more about why this was closed? Is there anything I can do to help land this change? |
@kraenhansen thanks for the contribution. It looks like a few tests are failing, do you see this locally? |
@bcoe this is my contribution; I'm looking into the failure right now! |
My bad sorry, I was half paying attention, and it was @kraenhansen who reached out to me. |
I was able to fix one test failure cause, which was that The second failure relates to |
@nwalters512 two options:
|
(1) would seem to be the easiest, as https://github.com/istanbuljs/istanbul-lib-processinfo doesn't consistently order items in the tree, and the order actually changes the output of the lines we do want because of how the tree is rendered. It's worth noting that this change will be visible to users, in the form of an extra line in the process tree like this:
We could conceivably catch that and filter it out by looking for something like this: execArgv[0] === '-e' && execArgv[1].indexOf('foreground-child watchdog pid') !== -1 I'm not sure if that's worth the effort, or how brittle that would end up being in the long run if/when |
@nwalters512 the process tree is pretty niche, I'm comfortable with commenting out these tests as long as the majority of tests work that exercise core behaviour. |
@nwalters512 friendly nudge on this one 😄 |
@bcoe I haven't forgotten about this! I'm AFK on my honeymoon, I'll be able to get back to this on the week of May 6. If there's an urgent need to land this in the meantime, don't hesitate to make changes on my behalf. |
Congrats! |
This should resolve #1535.