Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop coverage produced by nyc --all for files that were tested #1155

Merged
merged 2 commits into from Aug 2, 2019

Commits on Aug 1, 2019

  1. fix: Drop coverage produced by nyc --all for files that were tested

    Sometimes the coverage data produced by `nyc --all` is incompatible with
    the coverage data produced by actual test runs.  This is generally due
    to configuration error but results in inconsistent coverage reports or
    in some cases causes `nyc report` to crash.  The workaround is
    implemented in istanbul-lib-coverage to drop coverage data associated
    with `nyc --all` when coverage data from a test run is found.  This
    commit tags the coverage data when appropriate so the coverage merge
    logic knows what to do.
    
    Fixes istanbuljs#1113, istanbuljs#1124, istanbuljs#1148
    coreyfarrell committed Aug 1, 2019
    Copy the full SHA
    57832e1 View commit details
    Browse the repository at this point in the history
  2. chore: Stop constructing FileCoverage in noop instrumenter.

    This makes the behavior consistent with the real instrumenter which just
    provides raw data.
    coreyfarrell committed Aug 1, 2019
    Copy the full SHA
    990bdec View commit details
    Browse the repository at this point in the history