Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove vestigial environment variables #1078

Merged
merged 1 commit into from May 10, 2019
+2 −10
Merged

chore: remove vestigial environment variables #1078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions bin/nyc.js
View file
Open in desktop
Expand Up @@ -41,9 +41,7 @@ if ([
// https://github.com/istanbuljs/nyc/issues/951
SPAWN_WRAP_SHIM_ROOT: process.env.SPAWN_WRAP_SHIM_ROOT || process.env.XDG_CACHE_HOME || require('os').homedir(),
NYC_CONFIG: JSON.stringify(argv),
NYC_CWD: process.cwd(),
NYC_ROOT_ID: nyc.rootId,
NYC_INSTRUMENTER: argv.instrumenter
NYC_CWD: process.cwd()
}

if (argv['babel-cache'] === false) {
Expand Down
3 changes: 1 addition & 2 deletions bin/wrap.js
View file
Open in desktop
Expand Up @@ -8,8 +8,7 @@ config.isChildProcess = true
config._processInfo = {
pid: process.pid,
ppid: process.ppid,
parent: process.env.NYC_PROCESS_ID || null,
root: process.env.NYC_ROOT_ID
parent: process.env.NYC_PROCESS_ID || null
}
if (process.env.NYC_PROCESSINFO_EXTERNAL_ID) {
config._processInfo.externalId = process.env.NYC_PROCESSINFO_EXTERNAL_ID
Expand Down
2 changes: 0 additions & 2 deletions index.js
View file
Open in desktop
Expand Up @@ -21,7 +21,6 @@ const rimraf = require('rimraf')
const SourceMaps = require('./lib/source-maps')
const testExclude = require('test-exclude')
const util = require('util')
const uuid = require('uuid/v4')

const debugLog = util.debuglog('nyc')

Expand Down Expand Up @@ -89,7 +88,6 @@ class NYC {
this.fakeRequire = null

this.processInfo = new ProcessInfo(config && config._processInfo)
this.rootId = this.processInfo.root || uuid()

this.hashCache = {}
}
Expand Down
1 change: 0 additions & 1 deletion lib/process.js
View file
Open in desktop
Expand Up @@ -13,7 +13,6 @@ function ProcessInfo (defaults) {
this.cwd = process.cwd()
this.time = Date.now()
this.ppid = null
this.root = null
this.coverageFilename = null

for (var key in defaults) {
Expand Down
2 changes: 0 additions & 2 deletions test/processinfo.js
View file
Open in desktop
Expand Up @@ -65,7 +65,6 @@ t.test('validate the created processinfo data', t => {
execArgv: [],
cwd: fixturesCLI,
time: Number,
root: /^[0-9a-f]{8}-(?:[0-9a-f]{4}-){3}[0-9a-f]{12}$/,
coverageFilename: resolve(fixturesCLI, tmp, f),
files: [ resolvedJS ]
})
Expand All @@ -86,7 +85,6 @@ t.test('check out the index', t => {
},
externalIds: {
blorp: {
root: u,
children: [ u, u, u, u, u, u, u, u ]
}
}
Expand Down