feat: Add support for env.NYC_CONFIG_OVERRIDE #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a process to spawn a child process with an environment variable NYC_CONFIG_OVERRIDE. This is a JSON string which overrides any values in the NYC_CONFIG env. It is not deleted in the child process, so will be contagious unless unset, and it is the responsibility of the caller to manage. The first intended use case of this feature is to allow node-tap to map tests to the specific portion of a system under test that they cover. In this way, unit tests can be more focused, and only re-run when their specific unit has changed. There are, of course, many other uses that this could be put to, and it did not seem appropriate to add a special hook _just_ for overriding the include list.
|
@coreyfarrell #1078 removes some environs that are no longer load-bearing, if you're concerned about that. |
|
@isaacs I think removing unused environs in the next major release will be good but my concern is more about adding environmental variables which can be set from outside NYC to manipulate how it runs. |
bcoe
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
This is looking good to me, excited to see what you do with it.
Perhaps you can coordinate with @coreyfarrell (and his work here) to add the new tests as snapshots?
JaKXz
reviewed
Apr 22, 2019
There was a problem hiding this comment.
I echo @coreyfarrell's concern but I don't feel strongly enough about it to block the merge.
I appreciate the approach of adding new test files for new features!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a process to spawn a child process with an environment
variable NYC_CONFIG_OVERRIDE. This is a JSON string which overrides any
values in the NYC_CONFIG env. It is not deleted in the child process,
so will be contagious unless unset, and it is the responsibility of the
caller to manage.
The first intended use case of this feature is to allow node-tap to map
tests to the specific portion of a system under test that they cover.
In this way, unit tests can be more focused, and only re-run when their
specific unit has changed.
There are, of course, many other uses that this could be put to, and it
did not seem appropriate to add a special hook just for overriding
the include list.