Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use a single instance of nyc for all actions of main command. #1059

Merged
merged 1 commit into from Apr 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 12 additions & 24 deletions bin/nyc.js
Expand Up @@ -66,34 +66,22 @@ if ([
var mainChildExitCode = process.exitCode

if (argv.checkCoverage) {
checkCoverage(argv)
nyc.checkCoverage({
lines: argv.lines,
functions: argv.functions,
branches: argv.branches,
statements: argv.statements
}, argv['per-file'])
process.exitCode = process.exitCode || mainChildExitCode
if (!argv.silent) report(argv)
return done()
} else {
if (!argv.silent) report(argv)
return done()
}

if (!argv.silent) {
nyc.report()
}

return done()
})
} else {
// I don't have a clue what you're doing.
yargs.showHelp()
}

function report (argv) {
process.env.NYC_CWD = process.cwd()

var nyc = new NYC(argv)
nyc.report()
}

function checkCoverage (argv, cb) {
process.env.NYC_CWD = process.cwd()

;(new NYC(argv)).checkCoverage({
lines: argv.lines,
functions: argv.functions,
branches: argv.branches,
statements: argv.statements
}, argv['per-file'])
}