Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add processinfo index, add externalId #1055

Merged
merged 6 commits into from Apr 6, 2019

Commits on Apr 6, 2019

  1. THIS IS A WIP COMMIT FOR REVIEW ONLY, DO NOT MERGE

    Docs and tests still TK.  Future commit message follows.
    
    ---
    
    feat: add processinfo index, add externalId
    
    If a NYC_PROCESSINFO_EXTERNAL_ID environment variable is set, then it is
    saved in the processinfo as `externalId`.
    
    BREAKING CHANGE: This adds a file named 'index.json' to the
    .nyc_output/processinfo directory, which has a different format from the
    other files in this dir.
    
    Furthermore, when this file is generated, some additional helpful
    metadata is memoized to the processinfo json files, to minimize the cost
    of repeated generation.  (This isn't necessarily a breaking change, but
    it is an update to the de facto schema for those files.)
    
    As soon as possible, index generation and process tree display should be
    migrated out to a new 'istanbul-lib-processinfo' library.
    
    This opens the door to add features in the v14 release family to improve
    support for partial/resumed test runs and file watching.
    
    - When a process is run with --clean=false and a previously seen
      externalId, clear away all the coverage files in the set for that
      externalId.
    - When a file is changed, a test runner can use the index to determine
      which tests (by externalId) ought to be re-run.
    isaacs committed Apr 6, 2019
    Copy the full SHA
    0d40ec2 View commit details
    Browse the repository at this point in the history
  2. SQUASH: Update process index based on review

    - Adds a NYC_PROCESS_ID to environment
    - Adds `parent` to processInfo object, a uuid referring to parent.
    - Rebase onto processinfo-numeric-pids branch
    - Avoid re-writing the processinfo/{uuid}.json files
    
    Next:
    
    - Update process tree output to rely on process index instead of
      duplicating effort.
    isaacs committed Apr 6, 2019
    Copy the full SHA
    22fdb2e View commit details
    Browse the repository at this point in the history
  3. SQUASH: generate process tree using processinfo index

    Also, remove some unnecessary fields from process infos
    isaacs committed Apr 6, 2019
    Copy the full SHA
    362cdce View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    4c27fbf View commit details
    Browse the repository at this point in the history
  5. make the linter happy

    isaacs committed Apr 6, 2019
    Copy the full SHA
    6fa4332 View commit details
    Browse the repository at this point in the history
  6. remove unreachable code nit

    isaacs committed Apr 6, 2019
    Copy the full SHA
    967bcbf View commit details
    Browse the repository at this point in the history