fix: merge ranges properly when contained by other ranges in set #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/fix-merge-branches
branch
from
d8bcd36
to
a94fd20
Compare
|
@isaacs I'm not allowed to push to this branch - can you run |
SimenB
reviewed
Nov 3, 2023
| @@ -320,7 +411,7 @@ class FileCoverage { | |||
| ret.branches = this.computeBranchTotals('b'); | |||
| // Tracking additional information about branch truthiness | |||
| // can be optionally enabled: | |||
| if (this['bt']) { | |||
There was a problem hiding this comment.
If this was intentional, then the code should have a test, because it wasn't being covered.
There was a problem hiding this comment.
digging through #639 and linked efforts, seems like this was simply a typo
SimenB
approved these changes
Nov 3, 2023
isaacs
force-pushed
the
isaacs/fix-merge-branches
branch
from
a94fd20
to
4c9f38f
Compare
|
Fixed lint errors, PTAL, thanks :) |
SimenB
approved these changes
Nov 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: istanbuljs/v8-to-istanbul#233