New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nyc command line include parameter fix #84
Conversation
@alpersogukpinar nice approach 👍 |
exclude = testExclude(assign( | ||
{ cwd }, | ||
Object.keys(opts).length > 0 ? opts : { | ||
include: include, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer that we only set include if NYC_CONFIG.include
has been found; perhaps pull this object out into an object called defaults
; and only set the include
key if it's found?
1 similar comment
@bcoe I had tried to do something similar by setting include = false if process.env.NYC_CONFIG is undefined. I hope, this time I've changed the code as you suggested, if not please be more specific about the change :-) |
@alpersogukpinar haven't forgotten about this, and am hoping to have some OSS cycles in the coming week (have been on a binge working on a new major version of yargs recently). |
@alpersogukpinar merged this into a slightly different branch with tests, will have pull in a second 👍 |
@alpersogukpinar could you please give this a try:
I've landed your work, with a couple minor tweaks (including adding a couple tests for us). |
nyc command line include parameter was being ignored and package.json nyc/include values were being used everytime.
Fix #82