fix: prevent eslint errors from blocking build #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when we attempt to start our react app, create-react-app fails to compile when there are any eslint or prettier errors. The reason for this is documented in this github issue: facebook/create-react-app#9887 (comment) This issue is fixed with react-scripts v4.0.2 with the use of an ESLINT_NO_DEV_ERRORS env var (this is documented under advanced configuration here: https://create-react-app.dev/docs/advanced-configuration/) This commit adds the ESLINT_NO_DEV_ERRORS env var to our env-example file. We will need to separately add it to our production and staging environments too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, when we attempt to start our react app,
create-react-appfails to compile when there are any eslint or prettier errors. The reason for this is documented in this github issue: facebook/create-react-app#9887 (comment)This issue is fixed with react-scripts v
4.0.2with the use of anESLINT_NO_DEV_ERRORSenv var (this is documented under Create React App's advanced configuration here: https://create-react-app.dev/docs/advanced-configuration/)This commit adds the
ESLINT_NO_DEV_ERRORSenv var to our env-example file. We will need to separately add it to our production and staging environments too.To-dos
ESLINT_NO_DEV_ERRORSenv var to production and staging CMS frontend before merging into develop