Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-release.yml
Expand Up @@ -51,7 +51,7 @@ jobs:

const shaUrl = `${context.serverUrl}/${owner}/${repo}/commit/${{ inputs.check-sha }}`

let summary = `This check is assosciated with ${shaUrl}\n\n`
let summary = `This check is associated with ${shaUrl}\n\n`

if (jobUrl) {
summary += `For run logs, click here: ${jobUrl}`
Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:

const shaUrl = `${context.serverUrl}/${owner}/${repo}/commit/${{ inputs.check-sha }}`

let summary = `This check is assosciated with ${shaUrl}\n\n`
let summary = `This check is associated with ${shaUrl}\n\n`

if (jobUrl) {
summary += `For run logs, click here: ${jobUrl}`
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Expand Up @@ -114,7 +114,7 @@ jobs:

const shaUrl = `${context.serverUrl}/${owner}/${repo}/commit/${{ steps.release.outputs.pr-sha }}`

let summary = `This check is assosciated with ${shaUrl}\n\n`
let summary = `This check is associated with ${shaUrl}\n\n`

if (jobUrl) {
summary += `For run logs, click here: ${jobUrl}`
Expand Down Expand Up @@ -208,7 +208,7 @@ jobs:

const shaUrl = `${context.serverUrl}/${owner}/${repo}/commit/${{ steps.commit.outputs.sha }}`

let summary = `This check is assosciated with ${shaUrl}\n\n`
let summary = `This check is associated with ${shaUrl}\n\n`

if (jobUrl) {
summary += `For run logs, click here: ${jobUrl}`
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -10,7 +10,7 @@

### Bug Fixes

* [`57493ee`](https://github.com/npm/node-tar/commit/57493ee66ece50d62114e02914282fc37be3a91a) [#332](https://github.com/npm/node-tar/pull/332) ensuring close event is emited after stream has ended (@webark)
* [`57493ee`](https://github.com/npm/node-tar/commit/57493ee66ece50d62114e02914282fc37be3a91a) [#332](https://github.com/npm/node-tar/pull/332) ensuring close event is emitted after stream has ended (@webark)
* [`b003c64`](https://github.com/npm/node-tar/commit/b003c64f624332e24e19b30dc011069bb6708680) [#314](https://github.com/npm/node-tar/pull/314) replace deprecated String.prototype.substr() (#314) (@CommanderRoot, @lukekarrys)

### Documentation
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -909,7 +909,7 @@ The following options are supported:

If strict, emit an error with the provided message.

Othewise, emit a `'warn'` event with the provided message and data.
Otherwise, emit a `'warn'` event with the provided message and data.

### class tar.WriteEntry.Sync

Expand Down
2 changes: 1 addition & 1 deletion test/write-entry.js
Expand Up @@ -432,7 +432,7 @@ t.test('absolute path', t => {

t.test('preservePaths=true', t => {
t.plan(2)
// with preservePaths, strictness doens't matter
// with preservePaths, strictness doesn't matter
;[true, false].forEach(strict => {
t.test('strict=' + strict, t => {
const warnings = []
Expand Down