Avoid crash when fs is not available #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check fs.closeSync availability before calling fs.closeSync.toString() fs is not available in some environments. (such as React Typescript) But graceful-fs is still useful to run some module. (Such as exceljs)
NickAlvesX
approved these changes
Jul 6, 2019
|
This issue is very annoying. Please merge this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to generate Excel file in browser using React Typescript.
I am using exceljs library, and it depends on node-graceful-fs
dependency: exceljs#node-unzip-2#fstream#graceful-fs
But loading graceful-fs crashed because fs is not available in Browser.
I do not expect fs nor graceful-fs to run in browser.
I just want to avoid crash in startup sequence.