feat(cli): Echo the runner progress event, don't echo in runner

The CLI shall echo the progress, not the runner itself. Fixes karma-runner#2121, karma-runner#2799
is-already-taken · Apr 10, 2019 · 10b9833 · 10b9833
1 parent ea0b9c4
commit 10b9833
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/cli.js b/lib/cli.js
@@ -240,6 +240,10 @@ function describeCompletion () {
     .describe('help', 'Print usage.')
 }
 
+function printRunnerProgress(data) {
+  process.stdout.write(data)
+}
+
 exports.process = function () {
   const argv = optimist.parse(argsBeforeDoubleDash(process.argv.slice(2)))
   const options = {
@@ -291,7 +295,9 @@ exports.run = function () {
       new Server(config).start()
       break
     case 'run':
-      require('./runner').run(config)
+      require('./runner')
+        .run(config)
+        .on('progress', printRunnerProgress)
       break
     case 'stop':
       require('./stopper').stop(config)

diff --git a/lib/runner.js b/lib/runner.js
@@ -57,7 +57,6 @@ function run (config, done) {
       const parsedResult = parseExitCode(buffer, exitCode, config.failOnEmptyTestSuite)
       exitCode = parsedResult.exitCode
       emitter.emit('progress', parsedResult.buffer)
-      process.stdout.write(parsedResult.buffer)
     })
 
     response.on('end', () => done(exitCode))