secrecy: use const generics, remove array impl macros #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
impl_cloneable_secret_for_array
andimpl_debug_secret_for_array
macros from thesecrecy
crate in favor of usingconst
generics.The doctest in
secrecy
has been updated to illustrate the usage on a[AccountNumber; 3]
type as well.I am not 100% certain that the usage is correct, but if so, I think it is also more thoroughly demonstrated now that it includes the
Debug
impl on a type which delegates to the trait's defaultDebugSecret::debug_secret
method.