Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrecy: use const generics, remove array impl macros #949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nilslice
Copy link

@nilslice nilslice commented Jan 7, 2022

This PR removes the impl_cloneable_secret_for_array and impl_debug_secret_for_array macros from the secrecy crate in favor of using const generics.

The doctest in secrecy has been updated to illustrate the usage on a [AccountNumber; 3] type as well.

I am not 100% certain that the usage is correct, but if so, I think it is also more thoroughly demonstrated now that it includes the Debug impl on a type which delegates to the trait's default DebugSecret::debug_secret method.

@nilslice
Copy link
Author

@tony-iqlusion @Shella - just came across this old PR in a clean-up pass of my Github 😄

Should I close it or is this something you're open to?

@tony-iqlusion
Copy link
Member

We're still potentially interested. Please don't close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants