Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrecy/zeroize: Upgrade to bytes v0.5; MSRV 1.39+ #301

Merged
merged 2 commits into from Dec 2, 2019

Commits on Dec 2, 2019

  1. secrecy/zeroize: Upgrade to bytes v0.5

    - Removes the `bytes-preview` feature from `zeroize`
    - Upgrades `secrecy` to use `bytes` v0.5
    
    Now that `bytes` v0.5 is out, I've opened a PR to upstream the `Zeroize`
    impl for `BytesMut`:
    
    tokio-rs/bytes#335
    
    Unfortunately it's no-longer possible to impl `Zeroize` for `Bytes` as
    of `bytes` v0.5, as the `try_mut` method was dropped in this PR:
    
    tokio-rs/bytes#298
    
    I have brought this up on the first PR.
    
    In the meantime, this vendors the previous `BytesMut` impl of `Zeroize`
    into `secrecy`'s `SecretBytesMut` type, and drops `SecretBytes` as it's
    no-longer possible to implement.
    tony-iqlusion committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1ce1860 View commit details
    Browse the repository at this point in the history
  2. MSRV 1.39+

    `bytes` v0.5 now needs Rust 1.39.
    
    1.39 is a pretty foundational release in terms of adding `async`/`await`
    and we need to be able to target that in various ways ASAP.
    
    Note this change is to the documented/supported/tested MSRV. Crates will
    continue working on a lower-than-advertised MSRV for now.
    tony-iqlusion committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    c66b787 View commit details
    Browse the repository at this point in the history