Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroize: Remove CPU fences #216

Merged
merged 1 commit into from Jun 4, 2019
Merged

Commits on Jun 4, 2019

  1. zeroize: Remove CPU fences

    Per @RalfJung:
    
    #214 (comment)
    
    > AFAIK atomic fences only really prevent reordering of atomic accesses.
    > Non-atomic accesses can still be reordered. The interaction of this
    > with volatile accesses is entirely unclear -- technically, they are
    > non-atomic, but in practice it seems unlikely that the compiler would
    > perform such reorderings.
    > [...]
    > A compiler fence seems like a reasonable precaution and also helps
    > make sure the side-effects happens near where the programmer might
    > expect it, but a CPU fence to me sounds more like cargo cult.
    tony-iqlusion committed Jun 4, 2019
    Copy the full SHA
    5fb6511 View commit details
    Browse the repository at this point in the history