zeroize: Remove CPU fences #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @RalfJung: #214 (comment) > AFAIK atomic fences only really prevent reordering of atomic accesses. > Non-atomic accesses can still be reordered. The interaction of this > with volatile accesses is entirely unclear -- technically, they are > non-atomic, but in practice it seems unlikely that the compiler would > perform such reorderings. > [...] > A compiler fence seems like a reasonable precaution and also helps > make sure the side-effects happens near where the programmer might > expect it, but a CPU fence to me sounds more like cargo cult.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @RalfJung:
#214 (comment)