Polishing argcomplete support #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Forgot to add license notice on new files * Add support for completing subcommands. Its not easy to do this with argparse's subparser with the way traitlets uses argparse, so instead directly add subcommands as completions for the first cword in argcomplete. * A few other small refactor/cleanup/testing
Otherwise, this test prevents other tests from creating subcommand applications.
|
I've given you "Maintain" access on the repository, please feel free to close the relevant issues. |
|
Agreed the notebook test timeout is unrelated. I'll cut a minor release on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small improvements to #811:
subparserwith the way traitlets uses argparse, so instead directly add subcommands as completions for the first cword in argcomplete.