Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: decrease runtime overhead for constructing HasTraits (up to 20x faster) #777

Merged
merged 21 commits into from Dec 8, 2022
Merged

Performance: decrease runtime overhead for constructing HasTraits (up to 20x faster) #777

merged 21 commits into from Dec 8, 2022

Commits on Dec 8, 2022

  1. perf: find default generators at class contruction time 

    instead of at runtime, which gives a runtime overhead.
    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    4dbcd53 View commit details
    Browse the repository at this point in the history

  2. perf: find descriptors at class construction time

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a9a434b View commit details
    Browse the repository at this point in the history

  3. perf: only add notifiers when they exist

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7114fed View commit details
    Browse the repository at this point in the history

  4. perf: avoid cross_validation_lock context manager 

    this has a runtime overhead (about 20% faster without it)
    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    96dd844 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @maartenbreddels
    pre-commit-ci[bot] authored and maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e6d4159 View commit details
    Browse the repository at this point in the history

  6. perf: get app traits during class construction instead of runtime

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3890f72 View commit details
    Browse the repository at this point in the history

  7. typing

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    304e888 View commit details
    Browse the repository at this point in the history

  8. perf: avoid dynamic default code path for static immutable defaults

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5dd9d70 View commit details
    Browse the repository at this point in the history

  9. typing

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a72261d View commit details
    Browse the repository at this point in the history

  10. perf: avoid unnecessary dict presence checks

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a7c22ca View commit details
    Browse the repository at this point in the history

  11. more trivial immutable static initial values

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    05d3023 View commit details
    Browse the repository at this point in the history

  12. perf: better scaling due to skipping instance_init when possible.

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    aff9d0c View commit details
    Browse the repository at this point in the history

  13. perf: specialized version of hold_trait_notifications in ctor

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d0ec5ff View commit details
    Browse the repository at this point in the history

  14. perf: skip setup if no kwargs are given

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    bf33e88 View commit details
    Browse the repository at this point in the history

  15. fix: validate return value should be used

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    8e04ed9 View commit details
    Browse the repository at this point in the history

  16. flake8: unused variable

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5bb5924 View commit details
    Browse the repository at this point in the history

  17. perf: opt out instance_init for bool and enum

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    09ca954 View commit details
    Browse the repository at this point in the history

  18. perf: all instances that are None are immutable and static

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1c85d41 View commit details
    Browse the repository at this point in the history

  19. perf: remove usage of named attribute accesses on bunches

    @naterush @maartenbreddels
    naterush authored and maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    dae860f View commit details
    Browse the repository at this point in the history

  20. trigger ci

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1cc97d4 View commit details
    Browse the repository at this point in the history

  21. trigger ci

    @maartenbreddels
    maartenbreddels committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    36fdaf5 View commit details
    Browse the repository at this point in the history