Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some descriptors raise AttributeError #812

Merged
merged 1 commit into from Dec 12, 2022

Conversation

maartenbreddels
Copy link
Contributor

@maartenbreddels maartenbreddels commented Dec 9, 2022

Regression, noticed in #777 (comment)

Fixes #813

@jeffyjefflabs I think this should fix your issue, but I'd like to be able to add a test to prevent further regression, any ideas on this?

@rmorshea rmorshea added the bug label Dec 9, 2022
@jeffyjefflabs
Copy link

I can confirm that fixes it - thank you! I added a print statement and the class being set up when the error occurs is jupyter_client.provisioning.provisioner_base.KernelProvisionerBase. From the traceback, this is happening when sphinx sets up the myst_nb extension. Unfortunately our code isn't public, but we are actually calling sphinx programmatically after some other code runs. We do have zope.interface (mentioned in that comment) in the environment via twisted, so I'm guessing there's some interplay going on there. Unfortunately I'm not having any luck reproducing with a minimal repo generated by mystnb-quickstart, but hopefully this will give you some ideas.

@blink1073
Copy link
Member

I'll go ahead and cut a release with this.

@blink1073 blink1073 enabled auto-merge (squash) December 12, 2022 16:08
@blink1073 blink1073 merged commit aa0d38b into ipython:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 5.7.0 raises AttributeError: __provides__
4 participants