Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream ipykernel tests #14424

Merged
merged 4 commits into from May 6, 2024
Merged

Conversation

ianthomas23
Copy link
Collaborator

Locally I can get the downstream ipykernel tests to pass just by removing the explicit downgrade of pytest and pytest_asyncio, so here trying it in CI.

@ianthomas23
Copy link
Collaborator Author

This does fix the ipykernel tests. The subsequent sagemath tests also pass on ubuntu but fail on macos. I've tried switching to a specific mac Intel runner (macos-latest recently changing to be ARM) and playing with the sagemath pins but it hasn't helped. I am not sure how to continue.

@Carreau Carreau added this to the 8.25 milestone May 6, 2024
@Carreau
Copy link
Member

Carreau commented May 6, 2024

Thanks, merging. I also gave you triage right on the repo, as you've been contributing a lot. Hopefully that will make your life a bit easier. You don't have to use them though. Just recognition.

@Carreau Carreau merged commit e96ec57 into ipython:main May 6, 2024
17 of 19 checks passed
@ianthomas23 ianthomas23 deleted the fix_ipykernel_tests branch May 7, 2024 07:15
@ianthomas23
Copy link
Collaborator Author

I also gave you triage right on the repo, as you've been contributing a lot. Hopefully that will make your life a bit easier. You don't have to use them though. Just recognition.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants