Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaperilio/gui msg #14067

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Shaperilio/gui msg #14067

wants to merge 9 commits into from

Commits on May 2, 2023

  1. Add a requirements file for dev/testing

    @shaperilio
    shaperilio committed May 2, 2023
    Configuration menu
    Copy the full SHA
    914f707 View commit details
    Browse the repository at this point in the history

  2. Clean up logic and message only when needed.

    @shaperilio
    shaperilio committed May 2, 2023
    Configuration menu
    Copy the full SHA
    62e0b26 View commit details
    Browse the repository at this point in the history

  3. Remove what appears to be an unnecessary call. 

    I see no difference in e.g. Jupyter notebook. Removing this call
prevents the unnecessary installation of a
gui event loop hook.
    @shaperilio
    shaperilio committed May 2, 2023
    Configuration menu
    Copy the full SHA
    9d3ba8a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. BF: change logic so we can have just one else statement

    @shaperilio
    shaperilio committed May 3, 2023
    Configuration menu
    Copy the full SHA
    765ddb3 View commit details
    Browse the repository at this point in the history

  2. DOC: unnecessary call

    @shaperilio
    shaperilio committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6d01488 View commit details
    Browse the repository at this point in the history

  3. Revert "BF: change logic so we can have just one else statement" 

    This reverts commit 765ddb3; still need two else statements anyway.
    @shaperilio
    shaperilio committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c9170a7 View commit details
    Browse the repository at this point in the history

  4. BF: fix logic

    @shaperilio
    shaperilio committed May 3, 2023
    Configuration menu
    Copy the full SHA
    bc654f4 View commit details
    Browse the repository at this point in the history

  5. Tell which event loop hook was removed. 

    Consider making this a query, and make a `%gui off` actually remove it
    @shaperilio
    shaperilio committed May 3, 2023
    Configuration menu
    Copy the full SHA
    63f591f View commit details
    Browse the repository at this point in the history

  6. Formatting

    @shaperilio
    shaperilio committed May 3, 2023
    Configuration menu
    Copy the full SHA
    06a622c View commit details
    Browse the repository at this point in the history