Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib instead of os in IPython/{lib/demo,core/hooks} #13785

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use pathlib instead of os in IPython/{lib/demo,core/hooks} #13785

wants to merge 3 commits into from

Conversation

ChandanChainani
Copy link
Contributor

@ChandanChainani ChandanChainani commented Oct 13, 2022 •
edited

Progress for #12515

@ChandanChainani ChandanChainani changed the title Use pathlib instead of os in IPython/lib/demo Use pathlib instead of os in IPython/lib/demo, IPython/core/hooks Oct 13, 2022
@ChandanChainani ChandanChainani changed the title Use pathlib instead of os in IPython/lib/demo, IPython/core/hooks Use pathlib instead of os in IPython/{lib/demo,core/hooks} Oct 13, 2022
@ChandanChainani ChandanChainani force-pushed the feature/12515/cleanup_pathlib branch 3 times, most recently from a594c0b to 62f8e7d Compare October 14, 2022 14:32
@ChandanChainani
Copy link
Contributor Author

@Carreau please review the PR

@Carreau
Copy link
Member

Carreau commented Oct 17, 2022

Thanks for your PRs. Though there is 81 PRs in the list that are older than yours, and all the work here is volunteer. I'll do my best, but it is not likely to be fast.

@ChandanChainani
Copy link
Contributor Author

@Carreau Just want to check, Thanks you very much for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drunkwcodes drunkwcodes drunkwcodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChandanChainani @Carreau @drunkwcodes