Use pathlib.Path instead of os.path.join in test_interactiveshell.py
#13769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with open( | ||
| join(self.TESTDIR, "åäötestscript.py"), "w", encoding="utf-8" | ||
| ) as sfile: | ||
| with open(self.TESTDIR / "åäötestscript.py", "w", encoding="utf-8") as sfile: |
There was a problem hiding this comment.
Path objects have a method for writing text: path.write_text("text", encoding="utf-8")
There was a problem hiding this comment.
You're right, didn't even think of that. I don't know what causes the FileNotFoundError though
|
No idea why only windows-latest pypy-3.8 fails with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12515
This is my first ever pull request, please tell me if I did anything wrong